When I first re-did the tank a few years ago it was a lengthy process. Almost a week of nuts and bolts swimming around in acid, shake, shake, shake, dump, refill, repeat. But I got it cleaned up pretty well to where I wasn't nervous about running it.
Then - I opened the cap last night (photo) after it has been sitting since probably 2017-2018 with no fuel in it.
Thoughts? Should I just start the process again? Obviously the tank hadn't been repainted when I did it last time so I didn't care about the acid on the paint, but I do now. Would it be better/easier to just coat the inside?
It rusted from not coating it with 2 stroke oil when you emptied it.
Yes now you will need to derust it again before you use it(even if you decide to line it....I don't advise lining your tank.....).
Electrolysis cleaning works great with no damage to the paint. I have derusted many tanks this way, some have been rusted more than your tank is and have had great success. I follow up after rinsing out the washing soda mix with fresh water, dump out, then fill with Evaporust to the top for a couple days. Then dump the Evaporust back into the 5 gallon bucket to reuse on another tank. Then rinse the tank 4 times with 2 quarts of diesel fuel and shake to rinse and capture the moisture of the Evaporust. I dump the diesel fuel into another clean 5 gallon bucket (to save), pour in 2 more quarts of diesel fuel and shake again, repeat this rinsing 4 times. (The moisture separates and settles to the bottom of the bucket after a few days and you can drain off the diesel fuel to use the next time)
Then I coat the tank with 6-8 oz 2 stroke oil turning the tank so it coats all over including the top of the tank, then dump the excess oil. The coating will mix with the fresh gas you put in when you fill it. It won't hurt the carbs or motor. You can add 2 oz of 2 stroke oil to each fill up to preserve the tank will you are riding the bike too.
And you don't have to line the tank either, as long as the tank doesn't leak anyhow..
I drain my tanks each winter for storage and coat the tank with 2 stroke oil to preserve the tanks.