Had several pinholes in my CB550 tank - including a 'gash' that was about 1/2 inch long, and just wide enough to slip the tip of a pen knife into...
After much research and talking to radiator shops, etc., I was not getting the feeling that soldering alone was not necessary tons more reliable than a good quality patching compound and sealer. All of the tank repair shops indicated that they would seal it with Red Kote or similar after soldering anyway (FULL DISCLAIMER: I AM NOT EXPERIENCED WITH METALWORK, JUST TAKING THIS FROM WHAT THE GUYS AT THE SHOPS SAID).
I finally settled on using Caswell's epoxy liner, along with their epoxy tank patch
http://www.caswellplating.com/restoration-aids/epoxy-gas-tank-sealer.html It has been about a month or so and has held up very well (so far), especially considering the amount of patching that was required. You basically put on the patch, and then pour in the sealer, so it actually acts as a sort of 'double patch'.
I did loads and loads of searching and did not run across any negative stories about Caswell products.
That said - I did buy another tank that I am going to refurb because I want to have a solid tank - but I do trust the tank that's on there now.
The original tank needed new paint anyway, and had a small dent - so I mainly got the new tank becuz I didn't want to put the money into decals, supplies, etc. when I knew it was patched. If it had solid paint I would run as is and just continue to keep an eye on it.
And buying a new tank and refurbing gets way expensive way fast - even DIY, and it's still pretty tough to guarantee your not going to run into more pinholes
I just cleaned out this replacement over the holiday, and have decided to line it with Caswell's as well. It had some spotty rust which did come off without developing any leaks - but those tanks are so thin anyway, it seems that the Caswell's is a good insurance.
I have not used the other liners - but from what I have read - the Caswell's definitely seems a lot simpler to apply to the tank. The tank still needs to be clean and dry, but some rust will not harm adhesion (in fact, it is supposed to aid with adhesion - who knows?).
I also really like the concept of an epoxy vs. an air-dry product.
I might have tried the soldering if that was in my skill-set - I mean I can manage a plumbing fitting - and it may well be more solid than the epoxy patch - but thought I'd share my experience/solution with you